Fix Twitter linkcheck failure. #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twitter seems to be doing UserAgent sniffing, and rejecting non-browser user agents, breaking CI. This change makes htmltest use a Chrome Linux user agent to work around this issue. To support editing the HTTP headers required an update to htmltest.
markmandel
added
kind/bug
roberthbailey
approved these changes
Jan 12, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Succeeded 👏 Build Id: c8920c38-76b3-48d2-b99b-e96cb0d476e6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Twitter seems to be doing UserAgent sniffing, and rejecting non-browser user agents, breaking CI.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This change makes htmltest use a Chrome Linux user agent to work around this issue. To support editing the HTTP headers required an update to htmltest.